Any thoughts on this command? Does it work on your machine? Can you do the same thing with only 14 characters?
You must be signed in to comment.
commandlinefu.com is the place to record those command-line gems that you return to again and again. That way others can gain from your CLI wisdom and you from theirs too. All commands can be commented on, discussed and voted up or down.
Every new command is wrapped in a tweet and posted to Twitter. Following the stream is a great way of staying abreast of the latest commands. For the more discerning, there are Twitter accounts for commands that get a minimum of 3 and 10 votes - that way only the great commands get tweeted.
» http://twitter.com/commandlinefu
» http://twitter.com/commandlinefu3
» http://twitter.com/commandlinefu10
Use your favourite RSS aggregator to stay in touch with the latest commands. There are feeds mirroring the 3 Twitter streams as well as for virtually every other subset (users, tags, functions,…):
Subscribe to the feed for:
numLines=$(wc -l $ff | sed 's/ .*//g')
but I'd prefer to use bash and get rid of sed:numLines=$(wc -l $ff)
numLines=${numLines% *}
To save time, it's better to check the file length FIRST. Currently, you sort all the small files, then ignore the result:[ $numLines -lt 100 ] && continue
Now, you don't need the min variable any more:sort -nrk 1 $ff | tail -1 >> minValues
Next, I'd change that sort line again. Currently, it writes to 'minValues' one line at a time. If you've got a LOT of files, it'd be more efficient to do:sort -nrk 1 $ff | tail -1
done >> minValues
Finally, I'd quote the "$ff" just in case the filenames have whitespace in them.for ff in directory/*; do numLines=$(wc -l "$ff"); numLines=${numLines% *}; [ $numLines -lt 100 ] && continue; sort -nrk 1 "$ff" | tail -1; done >> minValues
188 characters down to 157 :-) Minimising it fully:for f in directory/*;do n=$(wc -l "$f");n=${n% *};[ $n -lt 100 ]&&continue;sort -nrk 1 "$f"|tail -1;done>>minValues
115 charactersfor f in directory/*;do n=$(wc -l "$f");n=${n% *};[ $n -lt 100 ]||sort -nrk 1 "$f"|tail -1;done>>minValues
106 characters